Skip to content

renamed to _generate_and_preprocess_model_data #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023
Merged

renamed to _generate_and_preprocess_model_data #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fc3ad9
renamed to _generate_and_preprocess_model_data
michaelraczycki Aug 21, 2023
559c113
including new naming in tests
michaelraczycki Aug 21, 2023
b20db6f
updating to 3.8 typehinting
michaelraczycki Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymc_experimental/linearmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def _data_setter(self, X: pd.DataFrame, y: Optional[Union[pd.DataFrame, pd.Serie
if y is not None:
pm.set_data({"y_data": y.squeeze()})

def generate_and_preprocess_model_data(
def _generate_and_preprocess_model_data(
self, X: Union[pd.DataFrame, pd.Series], y: pd.Series
) -> None:
"""
Expand Down
4 changes: 2 additions & 2 deletions pymc_experimental/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def _generate_and_preprocess_model_data(
Examples
--------
>>> @classmethod
>>> def generate_and_preprocess_model_data(self, X, y):
>>> def _generate_and_preprocess_model_data(self, X, y):
coords = {
'x_dim': X.dim_variable,
} #only include if applicable for your model
Expand Down Expand Up @@ -494,7 +494,7 @@ def fit(
if y is None:
y = np.zeros(X.shape[0])
y = pd.DataFrame({self.output_var: y})
self.generate_and_preprocess_model_data(X, y.values.flatten())
self._generate_and_preprocess_model_data(X, y.values.flatten())
self.build_model(self.X, self.y)

sampler_config = self.sampler_config.copy()
Expand Down
8 changes: 7 additions & 1 deletion pymc_experimental/tests/test_model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import json
import sys
import tempfile
from typing import Dict
from typing import Dict, Union

import numpy as np
import pandas as pd
Expand Down Expand Up @@ -122,6 +122,12 @@ def default_model_config(self) -> Dict:
"obs_error": 2,
}

def _generate_and_preprocess_model_data(
self, X: Union[pd.DataFrame, pd.Series], y: pd.Series
) -> None:
self.X = X
self.y = y

@property
def default_sampler_config(self) -> Dict:
return {
Expand Down