Skip to content

Termination criterion for nuts #1787

@aseyboldt

Description

@aseyboldt
Member

While reading through the stan code to double check the new implementation of multinomial sampling, I noticed that the termination criterion in stan is different to the one in pymc3. There have been recent changes in stan (stan-dev/stan#1854, stan-dev/stan#2180), but even in the older code ("classic nuts") it is different. pymc3 fails to take into account the metric and always assumes a unit mass matrix. This is probably because the original paper on nuts used the standard euclidean space.

Activity

twiecki

twiecki commented on Feb 14, 2017

@twiecki
Member

Yes, we haven't tracked their changes consistently. Should definitely bring our NUTS as much in sync with theirs as possible.

aseyboldt

aseyboldt commented on Mar 12, 2017

@aseyboldt
MemberAuthor

This was fixed in #1769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @twiecki@aseyboldt

        Issue actions

          Termination criterion for nuts · Issue #1787 · pymc-devs/pymc