Skip to content

Compile single function in InferenceDataConverter._extract_log_likelihood #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #7053
ricardoV94 opened this issue Dec 12, 2021 · 0 comments
Open
Tracked by #7053

Compile single function in InferenceDataConverter._extract_log_likelihood #5256

ricardoV94 opened this issue Dec 12, 2021 · 0 comments
Labels
help wanted maintenance trace-backend Traces and ArviZ stuff

Comments

@ricardoV94
Copy link
Member

After #5245 we no longer need to create one function per observed variable, which may be more efficient.

https://github.com/pymc-devs/pymc/blob/10523ef548d68848d6408f78d52fefea9be5c521/pymc/backends/arviz.py#L266-L271

This requires some understanding of how to feed the right information to the InferenceData object, possibly with some extra room for improvements in InferenceDataConverter.log_likelihood_vals_point which has a TODO as well:

https://github.com/pymc-devs/pymc/blob/10523ef548d68848d6408f78d52fefea9be5c521/pymc/backends/arviz.py#L240-L245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted maintenance trace-backend Traces and ArviZ stuff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94