-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add rng_fn
to CAR/ICAR
#7713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Plus some special logic for sparse covariances that would be nice to support in MvNormal as well? |
A hidden internal One issue I foresee is that we don't have sparse implementations of relevant algorithms (Cholesky, Eig, SVD, and Solve). I know sparse cholesky exists, because @bwengals was telling me it's a nice one for GP stuff. For the others I have no idea. But also beyond the scope of this issue |
Hi @jessegrabowski ! |
We don't assign issues, you can just open a PR |
Ok sure thing I'll open a draft one. |
Description
I was talking to @theorashid who linked me to this case study of CAR priors. It seems like they're just MvNormals, but with degenerate covariance matrices. We can now sample from such distributions use the new
method="eig"
ormethod="svd"
argument. So a potentialrng_fn
would just make an appropriate MvNormal with the method argument set, then return it's rng_fn.Looking at the
logp
method for these distributions, it seems like it's just using the eig method; so we might be able to simplify these to wrappers aroundMvNormalRV
that just constructs the mean/covariance and sets the appropriate method, but that's a step beyond what this PR is asking for.The text was updated successfully, but these errors were encountered: