Append underscore to transformed variable names #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2016 11:44
…e to underscore at the end of variable names
|
LGTM. I wonder if relying on a particular |
|
Thought about that as well, but given that it only gets used to hide output being displayed, the cost of the potential brittleness is pretty low. |
|
We could add a warning when you create a variable ending in an underscore. |
|
Doesn't seem like a huge deal either way. I'm also fine just mergnig as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer have to keep track of transformed variables due to this naming convention. Plots now exclude variables if the name contains an underscore (can be overridden with flag argument).
Closes #1168