Bounded now works with array bounds #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ColCarroll is it possible to refactor |
|
LGTM after the advice from @ferrine is taken on board. |
|
@ferrine i'm not sure what you mean by a |
|
@ColCarroll it is a class, not instance |
|
I'm still not sure what you mean -- do you have an example of your envisioned API? (or feel free to grab this branch and fix it!) |
|
@ColCarroll the following check should pass: |
|
ah, thank you! |
ColCarroll
force-pushed
the
fix_bounded
branch
from
2030c2d to
ccc603e
Compare
|
Does it still provide nonsense results? |
|
Yeah, it still provides nonsense results. |
|
Do we merge anyway? |
|
I'd be happy with a merge, since it doesn't appear to create any new bugs
(and contains some improvements). It seems like the nonsense results are a
separate problem, and someone else may have more bandwidth to fix that.
…On Mon, Dec 19, 2016 at 6:24 PM Peadar Coyle ***@***.***> wrote:
Do we merge anyway?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1604 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACMHED6idiD79J5TiG5X8pq20f8g2nHTks5rJxI5gaJpZM4LM7oy>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1491 . The sampling now runs, but produces nonsense results. Could use another set of eyes on this!
https://gist.github.com/ColCarroll/f003b12bf52b8e3893e2222a9a5f28ab
is the current output.