Make ElemwiseCategorical default. #2037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some test errors with isinstance. Is this an inheritance issue? |
fonnesbeck
reviewed
Apr 15, 2017
| q = np.copy(q0) | ||
| logp_curr = logp(q) | ||
|
|
||
| # TODO Replace loop with theano.scan |
There was a problem hiding this comment.
Can we do this when q is a numpy array?
There was a problem hiding this comment.
Yeah, that shouldn't be a problem.
|
I started having doubts on this. The elemwise sampler is much faster, but for more data points it should never accept a proposal. So I thin it's better to be accurate than fast. There are ways to speed this up. Ultimately though, people should just use the Mixture distributions. |
|
Sure - the MCMC might need some refactoring anyway in the near future. do you want to also delete the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1563