-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update create testenv #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create testenv #2229
Conversation
requirements.txt
Outdated
@@ -5,4 +5,5 @@ patsy>=0.4.0 | |||
joblib>=0.9 | |||
tqdm>=4.8.4 | |||
six>=1.10.0 | |||
h5py>=2.7.0 | |||
enum34>=1.1.6; python_version < '3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pymc3 runs nice on py3.6. Why do we force <3.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because Enum34 is only needed for py34, but not needed for py35 and py36.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'd be surprised if anyone was actually using python 3.3 or 3.2 at this point, but figured we'd allow for that :) More realistic would be python_version <= 2.7
33555a9
to
0f7f6b5
Compare
Should be ready to go once tests pass. Not sure if it was the problem, but a test (the |
This would have caught #2227, and should catch
pip install pymc3
issues in the future. I'm not sure what the effects of installing everything withpip
instead ofconda
are, but we'll see. I've marked itWIP
since there might be a merge conflict addingh5py
torequirements.txt
, as in #2228.