Skip to content

Update create testenv #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2017
Merged

Conversation

ColCarroll
Copy link
Member

This would have caught #2227, and should catch pip install pymc3 issues in the future. I'm not sure what the effects of installing everything with pip instead of conda are, but we'll see. I've marked it WIP since there might be a merge conflict adding h5py to requirements.txt, as in #2228.

requirements.txt Outdated
@@ -5,4 +5,5 @@ patsy>=0.4.0
joblib>=0.9
tqdm>=4.8.4
six>=1.10.0
h5py>=2.7.0
enum34>=1.1.6; python_version < '3.4'
Copy link
Member

@ferrine ferrine May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pymc3 runs nice on py3.6. Why do we force <3.4?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because Enum34 is only needed for py34, but not needed for py35 and py36.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'd be surprised if anyone was actually using python 3.3 or 3.2 at this point, but figured we'd allow for that :) More realistic would be python_version <= 2.7

@ColCarroll ColCarroll force-pushed the update_create_testenv branch from 33555a9 to 0f7f6b5 Compare May 27, 2017 22:21
@ColCarroll ColCarroll changed the title [WIP] Update create testenv Update create testenv May 27, 2017
@ColCarroll
Copy link
Member Author

Should be ready to go once tests pass.

Not sure if it was the problem, but a test (the ARM5_4 example, I think) was timing out (i.e., over 10:00) until I installed numpy, scipy, and mkl-service with conda. It passed last time at ~7mins, which is still ~1min longer than other jobs right now. I have to assume that's because it is using the pip installed theano, instead of installing from mater.

@twiecki twiecki merged commit b505f47 into pymc-devs:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants