-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Vi summary #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vi summary #2230
Conversation
This is a nice idea. |
I dont know if we want users having to set up explicit callbacks. Something more automated might be better; what about adding attributes to the approximation? |
Along those lines, I do like the sort of comprehensive summary tables that you get when running statsmodels. Maybe having a |
Maybe, maybe. So it seems like it will be really convenient to have such a property |
From another view I don't think that we can give user something more usefull than ELBO history. |
I think that |
I do like @fonnesbeck's idea of an @ferrine what other variables do you think users would track? I'm fine with this, even though I'm not a big fan of callbacks I don't have a better idea. |
Sometimes I track parameter difference, sometimes parameters themselves, sometimes it is an arbitrary function that depends on approximation (asvgd experiments). Generally I can't know in advance what I'll be interested in. All that stuff were one line functions but supplementary code was like a boilerplate. According to my experience I considered that this api fits all my needs. This Summary class is more like a util callback and better be moved to |
OK, that makes sense. Want to write a short test? |
Sure |
|
Are there any restrictions for merge because of upcoming 3.1? |
Not yet. I like Tracker. |
Other name ideas are |
|
Here I propose a simple thing to record arbitrary summary during variational inference. I considered not to wrap VI result yet as it makes code messy, less readable and developer friendly