Skip to content

#2899: (draft) add Weibull AFT and censoring examples #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

jazzmuesli
Copy link

@junpenglao
Copy link
Member

I think it is appropriate to put these notebooks under a new session and index them on the website:

@fonnesbeck
Copy link
Member

These are looking good. Make sure they are annotated with markdown cells throughout the notebook. Many of the comments can be moved out of code cells and into their own markdown cells. A bit of interpretive text at the end would be helpful too.

Copy link
Member

@AustinRochford AustinRochford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Chris that breaking some of the larger code cells apart and adding explanatory text would be good.

@springcoil
Copy link
Contributor

Any update on this @jazzmuesli?
It looks awesome in fact, with a bit of polish - this would make a great contribution to the docs - I agree with the structure suggested by @junpenglao

I think a bit more explanatory test would make this super!

@junpenglao
Copy link
Member

Thanks for the effort :) hope you can contribute next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants