Skip to content

Fix for #3225 Triangular c attribute #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Conversation

lucianopaz
Copy link
Member

Made Triangular c attribute be handled consistently with scipy.stats. Added a test for out of unit interval c values and updated example code from Triangular's docstring.

…istently with scipy.stats. Added test and updated example code.
Copy link
Contributor

@springcoil springcoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twiecki twiecki merged commit 3f098c3 into pymc-devs:master Nov 17, 2018
@twiecki
Copy link
Member

twiecki commented Nov 17, 2018

Thanks @lucianopaz!

ColCarroll pushed a commit to ColCarroll/pymc3 that referenced this pull request Nov 22, 2018
…istently with scipy.stats. Added test and updated example code. (pymc-devs#3253)
@lucianopaz lucianopaz deleted the iss3225 branch February 24, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants