Skip to content

Remove tracetab.py #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Remove tracetab.py #5479

merged 3 commits into from
Feb 17, 2022

Conversation

markvrma
Copy link
Contributor

Depending on what your PR does, here are a few things you might want to address in the description:

@twiecki
Copy link
Member

twiecki commented Feb 16, 2022

Thanks for taking this on!

pymc/__init__.py:55: in <module>
[11](https://github.com/pymc-devs/pymc/runs/5218313484?check_suite_focus=true#step:8:11)
    from pymc.backends.tracetab import *
[12](https://github.com/pymc-devs/pymc/runs/5218313484?check_suite_focus=true#step:8:12)
E   ModuleNotFoundError: No module named 'pymc.backends.tracetab'
[13](https://github.com/pymc-devs/pymc/runs/5218313484?check_suite_focus=true#step:8:13)
Error: Process completed with exit code 4.

Maybe look for tracetab in the codebase.

@markvrma
Copy link
Contributor Author

I think required changes have been made

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #5479 (924fcb5) into main (3d958ad) will increase coverage by 1.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5479      +/-   ##
==========================================
+ Coverage   80.23%   81.45%   +1.22%     
==========================================
  Files          82       81       -1     
  Lines       13941    14203     +262     
==========================================
+ Hits        11185    11569     +384     
+ Misses       2756     2634     -122     
Impacted Files Coverage Δ
pymc/__init__.py 100.00% <ø> (ø)
pymc/bart/bart.py 94.33% <0.00%> (-1.58%) ⬇️
pymc/distributions/simulator.py 86.11% <0.00%> (-0.66%) ⬇️
pymc/util.py 75.62% <0.00%> (-0.48%) ⬇️
pymc/bart/pgbart.py 95.23% <0.00%> (-0.37%) ⬇️
pymc/bart/tree.py 100.00% <0.00%> (ø)
pymc/initial_point.py 100.00% <0.00%> (ø)
pymc/distributions/bound.py 100.00% <0.00%> (ø)
pymc/smc/smc.py 97.90% <0.00%> (+<0.01%) ⬆️
pymc/step_methods/mlda.py 96.39% <0.00%> (+<0.01%) ⬆️
... and 31 more

@twiecki twiecki merged commit 11e69ea into pymc-devs:main Feb 17, 2022
@twiecki
Copy link
Member

twiecki commented Feb 17, 2022

Thanks @markvrma!

@markvrma markvrma deleted the remove_tracetab.py branch March 7, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants