Skip to content

Review docstrings checkmarcked as best practice #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Conversation

OriolAbril
Copy link
Member

Minor fixes to docstrings marked as best practices already so they can serve as example in the coming open source working sessions.

@OriolAbril OriolAbril requested a review from ricardoV94 June 22, 2022 08:08
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #5919 (f6e387f) into main (3bf95ce) will increase coverage by 0.03%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5919      +/-   ##
==========================================
+ Coverage   89.50%   89.53%   +0.03%     
==========================================
  Files          73       73              
  Lines       13267    13267              
==========================================
+ Hits        11874    11878       +4     
+ Misses       1393     1389       -4     
Impacted Files Coverage Δ
pymc/distributions/__init__.py 100.00% <ø> (ø)
pymc/distributions/continuous.py 97.98% <ø> (ø)
pymc/distributions/timeseries.py 78.64% <ø> (ø)
pymc/sampling.py 82.41% <ø> (ø)
pymc/smc/sample_smc.py 83.22% <ø> (ø)
pymc/smc/smc.py 96.45% <ø> (ø)
pymc/variational/approximations.py 87.32% <ø> (+0.62%) ⬆️
pymc/variational/opvi.py 87.04% <ø> (+0.02%) ⬆️
pymc/distributions/discrete.py 99.21% <85.71%> (-0.52%) ⬇️
pymc/__init__.py 100.00% <100.00%> (ø)
... and 14 more

@OriolAbril
Copy link
Member Author

Should be ready to merge now. If something else still needed fixing please take over to get it merged before the open source working sessions

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@michaelosthege michaelosthege merged commit 729f79c into main Jun 23, 2022
@michaelosthege michaelosthege deleted the docstring_review branch June 23, 2022 17:14
@michaelosthege michaelosthege added this to the v4.1.0 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants