Use separate argument in CustomDist for functions that return symbolic representations
#6462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
CustomDist for functions that return symbolic representations
ricardoV94
force-pushed
the
customdist_symbolic_func
branch
from
d45c662 to
d45446b
Compare
…c representations
ricardoV94
force-pushed
the
customdist_symbolic_func
branch
from
d45446b to
320135e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6462 +/- ##
==========================================
- Coverage 94.79% 85.97% -8.82%
==========================================
Files 148 148
Lines 27716 27730 +14
==========================================
- Hits 26272 23840 -2432
- Misses 1444 3890 +2446
|
michaelosthege
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial API introduced in #6361 of overloading the
randomkwarg and branching depending on whether the function returned PyTensor variables or failed whatsoever was pretty bad. For instance it would mask obvious errors like callingpm.Normal.dist(banana=...).Such errors won't be masked anymore, and the user must instead pass such functions to the
distkwarg. I added a temporary check to help users navigate the API change.It also cleans some stale references to Aesara