Skip to content

Renamed at aliases to pt #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

shreyas3156
Copy link
Contributor

What is this PR about?
Closes #6572.

  1. Renamed aliases from at to pt in modules, tests, and docs.
  2. Modified variable names from pt to pnt to avoid conflicts in tests/distributions/
  • test_continuous.py
  • test_multivariate.py
  • test_transform.py
  • util.py

Checklist

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #6577 (48cd01c) into main (4da5edf) will decrease coverage by 6.08%.
The diff coverage is 89.01%.

❗ Current head 48cd01c differs from pull request most recent head 66da2c5. Consider uploading reports for the commit 66da2c5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6577      +/-   ##
==========================================
- Coverage   92.02%   85.94%   -6.08%     
==========================================
  Files          92       92              
  Lines       15561    15561              
==========================================
- Hits        14320    13374     -946     
- Misses       1241     2187     +946     
Impacted Files Coverage Δ
pymc/logprob/joint_logprob.py 87.77% <ø> (-11.12%) ⬇️
pymc/distributions/truncated.py 34.50% <6.66%> (-64.79%) ⬇️
pymc/logprob/mixture.py 30.21% <10.00%> (-68.14%) ⬇️
pymc/func_utils.py 18.60% <25.00%> (-69.77%) ⬇️
pymc/logprob/scan.py 20.00% <25.00%> (-76.93%) ⬇️
pymc/math.py 52.65% <48.14%> (-17.40%) ⬇️
pymc/logprob/rewriting.py 83.33% <50.00%> (-13.73%) ⬇️
pymc/logprob/transforms.py 66.09% <55.35%> (-30.05%) ⬇️
pymc/logprob/censoring.py 62.88% <60.00%> (-36.09%) ⬇️
pymc/pytensorf.py 85.92% <72.22%> (-6.42%) ⬇️
... and 32 more

... and 9 files with indirect coverage changes

@ricardoV94
Copy link
Member

ricardoV94 commented Mar 13, 2023

Modified variable names from pt to pnt to avoid conflicts in tests/distributions/

Good catch. Mind renaming them to the explicit point?

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict. Otherwise looks good!

@shreyas3156 shreyas3156 force-pushed the rename-alias-pt-6572 branch from 294e5bf to 2eb8ea7 Compare March 13, 2023 18:45
@ricardoV94 ricardoV94 force-pushed the rename-alias-pt-6572 branch from f181dd6 to 48cd01c Compare March 13, 2023 20:03
@ricardoV94
Copy link
Member

I rebased on main. Will merge if tests pass :)

@ricardoV94 ricardoV94 force-pushed the rename-alias-pt-6572 branch from 48cd01c to 66da2c5 Compare March 13, 2023 20:38
@ricardoV94 ricardoV94 merged commit 0bda194 into pymc-devs:main Mar 13, 2023
@ricardoV94
Copy link
Member

Thanks a lot @shreyas3156

@shreyas3156 shreyas3156 deleted the rename-alias-pt-6572 branch April 23, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename at aliases to pt
2 participants