Ignore named variables that are not traceable in get_vars_in_point_list
#6741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6741 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 95 95
Lines 16204 16205 +1
==========================================
Hits 14907 14907
- Misses 1297 1298 +1
|
lucianopaz
requested changes
May 29, 2023
ricardoV94
force-pushed
the
tweak_get_vars_in_point_list
branch
from
be467d1 to
6b2a352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up when trying to do posterior predictive on pymc-devs/pymc-extras#168
It would consider a named_var that is now just a
ConstantDataorMutableDataas having a trace equivalent. Thecompile_forward_functionwould then fail because we can't pass constants or shared variables as explicit inputs to a PyTensor function📚 Documentation preview 📚: https://pymc--6741.org.readthedocs.build/en/6741/