Skip to content

Fix small typing error in sample overload #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

thomasaarholt
Copy link
Contributor

@thomasaarholt thomasaarholt commented May 29, 2023

What is this PR about?
This fixes a small error in the pm.sample overload introduced in #6709, following a discussion over at pyright's repo.

Checklist

Bugfixes

  • Fixes small typing error in pm.sample

📚 Documentation preview 📚: https://pymc--6743.org.readthedocs.build/en/6743/

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #6743 (8e6c64e) into main (fbc62d5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6743   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          95       95           
  Lines       16204    16204           
=======================================
  Hits        14907    14907           
  Misses       1297     1297           
Impacted Files Coverage Δ
pymc/sampling/mcmc.py 89.81% <ø> (ø)

@ricardoV94 ricardoV94 merged commit f3df36b into pymc-devs:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants