Skip to content

Make Model.str_repr robust to variables without monkey-patch #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 5, 2023

Closes #6311 which became even more annoying after the do/observe


📚 Documentation preview 📚: https://pymc--6942.org.readthedocs.build/en/6942/

@ricardoV94 ricardoV94 added the bug label Oct 5, 2023
@ricardoV94 ricardoV94 changed the title model.str_repr does not expect variables to have method monkey-patched model.str_repr no longer expects variables to have method monkey-patched Oct 5, 2023
@ricardoV94 ricardoV94 changed the title model.str_repr no longer expects variables to have method monkey-patched Model.str_repr no longer expects variables to have method monkey-patched Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #6942 (d65db13) into main (df7b267) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6942      +/-   ##
==========================================
+ Coverage   91.78%   92.17%   +0.38%     
==========================================
  Files         100      100              
  Lines       16845    16847       +2     
==========================================
+ Hits        15462    15528      +66     
+ Misses       1383     1319      -64     
Files Coverage Δ
pymc/printing.py 88.09% <100.00%> (+0.19%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ricardoV94 ricardoV94 force-pushed the fix_model_str_repr branch 3 times, most recently from 601d078 to 9e16351 Compare October 11, 2023 13:29
@ricardoV94 ricardoV94 changed the title Model.str_repr no longer expects variables to have method monkey-patched Make Model.str_repr robust to variables without monkey-patch Oct 11, 2023
@ricardoV94 ricardoV94 merged commit 6f4a040 into pymc-devs:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not expect model variables to always have str_repr
3 participants