Skip to content

Refactored RV _print_name to long names #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

shreyas3156
Copy link
Contributor

Motivation for these changes

Closes #204

Implementation details

Renamed the RV names in _print_name to their long versions.

Checklist

Major / Breaking Changes

  • none

@shreyas3156 shreyas3156 changed the title Refactored RV _print_name to long names Refactored RV _print_name to long names Mar 12, 2023
Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @shreyas3156 for your help! :)

Minor note for ourselves: we would have to adapt tests from pymc/tests/test_printing.py accordingly once a new release for PyTensor is cut/pinned for PyMC.

@shreyas3156 shreyas3156 force-pushed the refactor-print-name-204 branch from 00abe9d to 045bc06 Compare March 21, 2023 07:00
@ricardoV94 ricardoV94 merged commit 4317d0d into pymc-devs:main Mar 22, 2023
@ricardoV94
Copy link
Member

Thanks @shreyas3156!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor _print_name for certain RVs?
3 participants