Remove non-Python files from package #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlsmedstad
changed the title
carlsmedstad
force-pushed
the
243-python-package-files
branch
from
88040d4 to
f5c863a
Compare
|
Uh the code style failure is the same as in #240, I assumed it was a Python3.10 specific thing, but it is not the case then. https://github.com/pymc-devs/pytensor/actions/runs/4712555504/jobs/8357675677?pr=276 |
carlsmedstad
force-pushed
the
243-python-package-files
branch
from
f5c863a to
1b19fb0
Compare
carlsmedstad
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 80.47% 80.36% -0.11%
==========================================
Files 171 153 -18
Lines 45442 44875 -567
Branches 11095 10991 -104
==========================================
- Hits 36569 36064 -505
+ Misses 6640 6606 -34
+ Partials 2233 2205 -28
|
maresb
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes
Fixes #243.
Implementation details
Tried to replicate what has been done in Aesara pretty closely.
I'm note very familiar with testing etc. for this project so I would appreciate if someone could take the reigns from here.