Skip to content

Make Constant and Shared variables subclasses of the respective Variables #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardoV94
Copy link
Member

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 changed the title Make Constant and Shared variables subclasses of the basic Variable types Make Constant and Shared variables subclasses of the related Variables Feb 5, 2024
@ricardoV94 ricardoV94 changed the title Make Constant and Shared variables subclasses of the related Variables Make Constant and Shared variables subclasses of the respective Variables Feb 5, 2024
@ricardoV94 ricardoV94 force-pushed the make_sparse_constant_instance_of_variable branch from 85fe968 to ba3fa31 Compare February 5, 2024 13:43
@ricardoV94 ricardoV94 force-pushed the make_sparse_constant_instance_of_variable branch from ba3fa31 to 75bae10 Compare February 5, 2024 15:32
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (fba91f1) 80.82% compared to head (75bae10) 80.82%.
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files         162      162           
  Lines       46743    46744    +1     
  Branches    11419    11418    -1     
=======================================
+ Hits        37781    37783    +2     
+ Misses       6717     6716    -1     
  Partials     2245     2245           
Files Coverage Δ
pytensor/breakpoint.py 55.00% <100.00%> (ø)
pytensor/compile/compilelock.py 97.14% <ø> (ø)
pytensor/configdefaults.py 65.92% <ø> (ø)
pytensor/gradient.py 76.82% <ø> (ø)
pytensor/graph/basic.py 88.76% <100.00%> (ø)
pytensor/graph/features.py 65.31% <100.00%> (ø)
pytensor/graph/rewriting/basic.py 71.03% <100.00%> (ø)
pytensor/graph/rewriting/db.py 85.96% <100.00%> (ø)
pytensor/graph/rewriting/unify.py 99.34% <100.00%> (ø)
pytensor/link/basic.py 87.39% <100.00%> (ø)
... and 47 more

@ricardoV94 ricardoV94 marked this pull request as ready for review March 20, 2024 14:46
@michaelosthege michaelosthege merged commit 60e2510 into pymc-devs:main Mar 24, 2024
@ricardoV94 ricardoV94 mentioned this pull request Jun 17, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared and Constants are not instances of respective Variables
3 participants