-
Notifications
You must be signed in to change notification settings - Fork 81
Closed
Labels
Description
I'm not 100% sure the pre-commit checks are fully/properly working for ruff formatting of notebooks. Currently we have:
CausalPy/.pre-commit-config.yaml
Lines 26 to 35 in 9a4daf7
- repo: https://github.com/astral-sh/ruff-pre-commit | |
rev: v0.4.3 | |
hooks: | |
- id: ruff | |
args: ["--fix", "--output-format=full"] | |
- id: ruff-format | |
- repo: https://github.com/nbQA-dev/nbQA | |
rev: 1.8.5 | |
hooks: | |
- id: nbqa-ruff |
Maybe we don't need nbQA
at all and solely use ruff-pre-commit
? The README at https://github.com/astral-sh/ruff-pre-commit shows that it's pretty simple to make it apply to Jupyter notebooks.