Skip to content

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 3, 2024

Scipy 1.13.0 was released on the 2nd of April 2024. Some tests are failing, and I want to test if it is due to the last release.

I suggest we pin this for now and create an issue to make it compatible.


📚 Documentation preview 📚: https://pymc-marketing--608.org.readthedocs.build/en/608/

@juanitorduz juanitorduz changed the title Test scipy Test scipy==1.13.0 Apr 3, 2024
@juanitorduz juanitorduz changed the title Test scipy==1.13.0 Restrict scipy<1.13.0 Apr 3, 2024
@juanitorduz juanitorduz self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (f055f98) to head (6efaf6e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          22       22           
  Lines        2267     2267           
=======================================
  Hits         2081     2081           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz
Copy link
Collaborator Author

Actually, I think its coming from arviz:

from scipy.signal import convolve, convolve2d, gaussian

In anaconda3/envs/pymc-marketing-env-docs/lib/python3.11/site-packages/arviz/stats/density_utils.py:8

Not in pymc marketing itself!

Actually, it was already fixed arviz-devs/arviz#2332 so we just need a release 🙂

@twiecki
Copy link
Contributor

twiecki commented Apr 3, 2024

Should we close this then?

@drbenvincent
Copy link
Contributor

Actually, it was already fixed arviz-devs/arviz#2332 so we just need a release 🙂

Do we have a timeline for when this might happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants