Export Cython functions into pcap.pxd #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pcap.pxd created in order to permit to others Cython module to use C functions and other Cython structures - pcap.pyx updated in order to remove code moved into pcap.pxd
hellais
reviewed
Feb 14, 2018
| timeout_ms -- requests for the next packet will return None if the timeout | ||
| (in milliseconds) is reached and no packets were received | ||
| (Default: no timeout) | ||
| immediate -- disable buffering, if possible |
There was a problem hiding this comment.
Is it necessary to have the docstring repeated in both the pcap.pyx and pcap.pxd file?
hellais
reviewed
Feb 14, 2018
| __copyright__ = 'Copyright (c) 2004 Dug Song' | ||
| __license__ = 'BSD license' | ||
| __url__ = 'https://github.com/pynetwork/pypcap' | ||
| __version__ = '1.2.0' |
There was a problem hiding this comment.
Same here, can we have these be defined in only one of the two places? Otherwise it becomes a bit more painful to keep them in sync, especially when bumping the version.
hellais
reviewed
Feb 14, 2018
| DLT_PRONET = 4 | ||
| DLT_CHAOS = 5 | ||
| DLT_IEEE802 = 6 | ||
| DLT_ARCNET = 7 |
There was a problem hiding this comment.
Should fix the spacing in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not (yet) Python/Cython code that uses pypcap so I have NOT try my mods on python code which use pypcap (I have only test the compilation process)