feat: Be more lenient on errors if app.config.sphinxjs_lax is set #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikrose
suggested changes
Sep 13, 2019
ptbrowne
force-pushed
the
lax
branch
2 times, most recently
from
878f64c to
f7dcbdf
Compare
erikrose
suggested changes
Sep 13, 2019
ptbrowne
force-pushed
the
lax
branch
2 times, most recently
from
f687c6c to
27ce82f
Compare
|
Should be OK now, thanks for the review. |
erikrose
suggested changes
Sep 16, 2019
ptbrowne
force-pushed
the
lax
branch
5 times, most recently
from
7334423 to
7d61e95
Compare
erikrose
suggested changes
Sep 24, 2019
hoodmane
pushed a commit
to hoodmane/sphinx-js
that referenced
this pull request
May 2, 2024
hoodmane
added a commit
to hoodmane/sphinx-js
that referenced
this pull request
May 2, 2024
…) (pyodide#116) The parameter `jsdoc_config_path` was pointing to `typedoc --tsconfig` which is the compiler options, it should be the typedoc configuration `typedoc --options` I added a parameter `jsdoc_tsconfig_path` to be able to specify the `typedoc --tsconfig` if needed I updated unit test and doc. It is a breaking change so we might want to bump version or add migration note. Available to update the PR as needed.
|
I'm sorry, but we're shutting down this project. You could look at making these changes to sphinx-js-fork if they're not made already. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating sphinxjs for a multi repository documentation site, I stumbled
upon several conflicts errors and
Rule 'path_and_formal_params' didn't match at(#109).For my usecase, it is more convenient to ignore those errors and fix them
on a case by case basis, so I do not mind if I ignore those doclets.
This PR adds a config attribute
sphinxjs_laxthat make sphinxjs doclet generationnot fail if it has errors.