Fix name normalization bug #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group names were not being normalized when loaded from includes. As a result, they didn't match the normalized names used for the loaded groups. This updates the internal name usage to be normalized during resolution. Errors will still contain the non-normalized name which the user used if possible (see: the `CyclicDependencyError` parameters). A new test confirms the fix, and fails without it.
henryiii
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group names were not being normalized when loaded from includes. As a result, they didn't match the normalized names used for the loaded groups.
This updates the internal name usage to be normalized during resolution. Errors will still contain the non-normalized name which the user used if possible (see: the
CyclicDependencyErrorparameters).A new test confirms the fix, and fails without it.
Initially reported via
pipv25.1 in pypa/pip#13372cc @henryiii , I intend to merge this and cut a release to fix pretty quickly, assuming CI passes.
📚 Documentation preview 📚: https://dependency-groups--26.org.readthedocs.build/en/26/