Skip to content

get-pip no longer works with explicit args for pip #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mihnea-dobrescubalaur-hs opened this issue Oct 5, 2018 · 6 comments
Closed

get-pip no longer works with explicit args for pip #37

mihnea-dobrescubalaur-hs opened this issue Oct 5, 2018 · 6 comments

Comments

@mihnea-dobrescubalaur-hs
Copy link

Hi!

Try curl https://bootstrap.pypa.io/get-pip.py | python - pip==18.0 and you will see that a DoubleRequirement exception is thrown. If you debug a bit, you'll find that actually InstallRequirement.from_line fails (InstallRequirement does not have from_line) and that triggers the continue call in the loop.

Thanks!
@rbreslow
Copy link

rbreslow commented Oct 5, 2018

I'm also getting this. Our Ansible provisioning that uses get-pip.py is broken. https://github.com/azavea/ansible-pip

@benoit-pierre
Copy link
Member

See pypa/pip#5857

benoit-pierre added a commit to benoit-pierre/get-pip that referenced this issue Oct 5, 2018
@benoit-pierre
fix pypa#37
0b40331
@benoit-pierre
Copy link
Member

As a temporary workaround, you can use a constraint, e.g.: python get-pip.py -c <(echo 'pip==18.0').

@hectcastro hectcastro mentioned this issue Oct 5, 2018
Closed
KaiSforza added a commit to KaiSforza/salt-jenkins that referenced this issue Oct 5, 2018
@KaiSforza
Update pip install command
48c5acd 
`get-pip.py` is no longer working with just specifying a pip version on
the command line (see pypa/get-pip#37 ) so we have to do some shell
redirection for a constraints file. This will cause us to install pip
9.0.1 or less, as intended. It *should* work. This also modifies the
python 2 version.
@KaiSforza KaiSforza mentioned this issue Oct 5, 2018
Merged
KaiSforza added a commit to KaiSforza/salt-jenkins that referenced this issue Oct 5, 2018
@KaiSforza
Update pip install command
3f570a1 
`get-pip.py` is no longer working with just specifying a pip version on
the command line (see pypa/get-pip#37 ) so we have to do some shell
redirection for a constraints file. This will cause us to install pip
9.0.1 or less, as intended. It *should* work. This also modifies the
python 2 version.
KaiSforza added a commit to KaiSforza/salt-jenkins that referenced this issue Oct 5, 2018
@KaiSforza
Update pip install command
7d71a40 
`get-pip.py` is no longer working with just specifying a pip version on
the command line (see pypa/get-pip#37 ) so we have to do some shell
redirection for a constraints file. This will cause us to install pip
9.0.1 or less, as intended. It *should* work. This also modifies the
python 2 version.
This was referenced Oct 5, 2018
Merged
Merged
KaiSforza added a commit to KaiSforza/salt-jenkins that referenced this issue Oct 5, 2018
@KaiSforza
Update pip install command
b3359c8 
`get-pip.py` is no longer working with just specifying a pip version on
the command line (see pypa/get-pip#37 ) so we have to do some shell
redirection for a constraints file. This will cause us to install pip
9.0.1 or less, as intended. It *should* work. This also modifies the
python 2 version.
@KaiSforza KaiSforza mentioned this issue Oct 5, 2018
Merged
@cloneluke
Copy link

duplicate: pypa/pip#5859

@tianon tianon mentioned this issue Oct 6, 2018
Closed
antonym pushed a commit to antonym/rpc-upgrades that referenced this issue Oct 8, 2018
Use constraints instead of args for get-pip
db7f09c 
Bug introduced in pypa/get-pip#37
breaks args
@antonym antonym mentioned this issue Oct 8, 2018
Closed
@cloneluke
Copy link

another workarond is hardcode pip url to prior version:

https://github.com/raw/pypa/get-pip/f88ab195ecdf2f0001ed21443e247fb32265cabb/get-pip.py

cloneluke pushed a commit to cloneluke/airflow-cookbook that referenced this issue Oct 8, 2018
allow get_pip_url to be set in the case of get_pip being broken, like p…
ed752a4 
…ypa/get-pip#37

you can override get_pip_url to prior version likehttps://github.com/raw/pypa/get-pip/f88ab195ecdf2f0001ed21443e247fb32265cabb/get-pip.py
@pradyunsg pradyunsg mentioned this issue Oct 8, 2018
Closed
@pradyunsg
Copy link
Member

Thanks @benoit-pierre for the investigation and PR! :)

This didn't show up in my manual "does it install pip on running?" check for get-pip.py prior to the release.

I guess it shows we really need to do #18. Help on that front would be appreciated. :)

@pradyunsg pradyunsg mentioned this issue Oct 8, 2018
Closed
This was referenced Oct 8, 2018
Merged
Merged
jaraco added a commit that referenced this issue Jan 6, 2022
@jaraco
Prefer find_spec to less invasively detect the presence of setuptools…
787e713 
… and wheel. Fixes #37.
jaraco added a commit that referenced this issue Jan 6, 2022
@jaraco
Prefer find_spec to less invasively detect the presence of setuptools…
2cfb2d5 
… and wheel. Fixes #37.
jaraco added a commit that referenced this issue Jan 7, 2022
@jaraco
Prefer find_spec to less invasively detect the presence of setuptools…
26416a4 
… and wheel. Fixes #37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rbreslow @pradyunsg @benoit-pierre @cloneluke @mihnea-dobrescubalaur-hs