Skip to content

Add GitHub Actions CI integration #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Sep 17, 2019

Using nox, pytest, and GitHub actions.

@chrahunt chrahunt force-pushed the maint/add-ci branch 10 times, most recently from cd64c93 to 7494ca9 Compare September 17, 2019 04:47
@chrahunt
Copy link
Member Author

See run here.

@webknjaz
Copy link
Member

#23 / #18

@chrahunt
Copy link
Member Author

Thanks!

To justify this change in the context of the comments brought up previously (you know this better than me, but for others reading):

  1. Since GitHub actions supports cron out of the box, we can hook it in very easily to do e.g. a nightly test against pip master
  2. GitHub actions supports Windows, Linux, and macOS out of the box, so there's much less complexity - no need to get org admins to set anything up with third-party CI providers

I also wanted to pick up #31 but felt it would be hard to do confidently without an easy way to test that it works outside of "my machine", so this seems like a prereq to me.

@chrahunt chrahunt requested a review from pfmoore September 19, 2019 00:44
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not at all familiar with whatever this is (Github workflows?) I'd rather someone else reviewed it. But if there isn't already, adding a pointer in our developer docs to the github workflows documentation, to allow people to find out about how this works, would probably be useful...

@webknjaz
Copy link
Member

@pfmoore it's a new built-in CI/CD that GitHub itself now provides. https://github.com/features/actions/signup

@pfmoore
Copy link
Member

pfmoore commented Sep 19, 2019

Thanks. I'm still not a good person to review (and don't have much time at the moment anyway) but what's the benefit of using this over Travis and Azure which we already use? Do we need another CI? Is it a good idea to tie ourselves more closely to Github? Diversity seems like a good thing to me (I'm thinking of Bitbucket dropping Mercurial support here...)

@webknjaz
Copy link
Member

@pfmoore GitHub Actions are more performant and allow up to 20 parallel jobs. And there's a number of other benefits. Talking about vendor-lock, I wouldn't call it that. After all, we're running some commands in some CI, it's fairly easy to migrate the same commands to run in another CI. This one just happens to be better integrated with GH, shows results right in GitHub's UI and allows reusing sharable components which is quite handy.

@webknjaz
Copy link
Member

Oh, and this specific repo doesn't have any CI connected. There's been several PRs but nobody seemed to agree that it's needed.

@pradyunsg pradyunsg changed the title Add CI. Add GitHub Actions CI integration Sep 19, 2019
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK to merge this as is. I feel like the configuration could use some polishing but I'm happy to merge this in eagerly and iterate on this as we go.

@pfmoore
Copy link
Member

pfmoore commented Sep 19, 2019

Whoa, sorry - I completely missed that this was get-pip not pip (both sets of notifications sort into the same folder for me). My apologies.

In that case, I guess I have no problem with picking github for the CI for this project. You can also ignore my comment about a pointer in the docs, which isn't relevant here.

@pradyunsg pradyunsg merged commit b02fc1c into pypa:master Sep 19, 2019
@chrahunt chrahunt deleted the maint/add-ci branch September 19, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants