-
Notifications
You must be signed in to change notification settings - Fork 311
Add GitHub Actions CI integration #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cd64c93
to
7494ca9
Compare
7494ca9
to
12fe895
Compare
See run here. |
Thanks! To justify this change in the context of the comments brought up previously (you know this better than me, but for others reading):
I also wanted to pick up #31 but felt it would be hard to do confidently without an easy way to test that it works outside of "my machine", so this seems like a prereq to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not at all familiar with whatever this is (Github workflows?) I'd rather someone else reviewed it. But if there isn't already, adding a pointer in our developer docs to the github workflows documentation, to allow people to find out about how this works, would probably be useful...
@pfmoore it's a new built-in CI/CD that GitHub itself now provides. https://github.com/features/actions/signup |
Thanks. I'm still not a good person to review (and don't have much time at the moment anyway) but what's the benefit of using this over Travis and Azure which we already use? Do we need another CI? Is it a good idea to tie ourselves more closely to Github? Diversity seems like a good thing to me (I'm thinking of Bitbucket dropping Mercurial support here...) |
@pfmoore GitHub Actions are more performant and allow up to 20 parallel jobs. And there's a number of other benefits. Talking about vendor-lock, I wouldn't call it that. After all, we're running some commands in some CI, it's fairly easy to migrate the same commands to run in another CI. This one just happens to be better integrated with GH, shows results right in GitHub's UI and allows reusing sharable components which is quite handy. |
Oh, and this specific repo doesn't have any CI connected. There's been several PRs but nobody seemed to agree that it's needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK to merge this as is. I feel like the configuration could use some polishing but I'm happy to merge this in eagerly and iterate on this as we go.
Whoa, sorry - I completely missed that this was get-pip not pip (both sets of notifications sort into the same folder for me). My apologies. In that case, I guess I have no problem with picking github for the CI for this project. You can also ignore my comment about a pointer in the docs, which isn't relevant here. |
Using nox, pytest, and GitHub actions.