Skip to content

Add Python 3.5 compatible get-pip.py #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Conversation

pradyunsg
Copy link
Member

This isn't sufficient on it's own -- we'd also need to update psf-salt for this.

@pradyunsg pradyunsg merged commit c2c075c into pypa:master Jan 24, 2021
@pradyunsg pradyunsg deleted the add-3.5 branch January 24, 2021 09:58
@pradyunsg
Copy link
Member Author

/cc @pfmoore @ewdurbin

@pfmoore
Copy link
Member

pfmoore commented Jan 24, 2021

Thanks for catching this, @pradyunsg - with the focus on dropping 2.7, I'd missed that we were also dropping 3.5 support.

@ewdurbin if you can make the salt changes (again!) that would be great.

@pfmoore
Copy link
Member

pfmoore commented Jan 24, 2021

I wonder if we'd be better with a file structure that put the legacy versions under our control:

+- pip
   +- get-pip.py
   +- 2.6
       +- get-pip.py
   +- 2.7
       +- get-pip.py
   ... (etc)

We'd obviously need to make links for the existing names, but future names could just sit under pip and not need changes to the salt config?

@pradyunsg
Copy link
Member Author

Yup. That's what #61 is all about. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants