_check_hash breaks in pypy

[hukka]

Exception:
Traceback (most recent call last):
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/basecommand.py", line 105, in main
    status = self.run(options, args)
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/commands/install.py", line 255, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/req.py", line 1022, in prepare_files
    self.unpack_url(url, location, self.is_download)
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/req.py", line 1146, in unpack_url
    retval = unpack_http_url(link, location, self.download_cache, self.download_dir)
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/download.py", line 465, in unpack_http_url
    _check_hash(download_hash, link)
  File "/home/tpievila/work/pas/ingest-hg/.tox/pypy/site-packages/pip-1.1.post2-py2.7.egg/pip/download.py", line 326, in _check_hash
    if download_hash.name != link.hash_name:
AttributeError: 'HASH' object has no attribute 'name'

Minimal testcase of the difference between cpython and pypy:

$ pypy -c "import hashlib; print(hashlib.md5().name)"Traceback (most recent call last):
  File "app_main.py", line 51, in run_toplevel
  File "app_main.py", line 575, in run_it
  File "<string>", line 1, in <module>
AttributeError: 'HASH' object has no attribute 'name'

[hukka]

I guess that since PEP 247 doesn't mention the .name attribute, it isn't part of the public API even when it's not prefixed with _...

[pnasrat]

@dstufft wrote the hashlib code - Donald can you look at PEP 247 and fix this up so we can work on pypy

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.