-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Replace more pkg_resources usages #10157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46762cd
to
df04434
Compare
f3c5344
to
e11c182
Compare
So it turns out the test suite actually made guarantees to output non-normalised package names, so I added a method for that and reverted a part of #9825 so |
ef1568f
to
b6e2355
Compare
b03156f
to
d442826
Compare
9982815
to
cf7d7f8
Compare
cf7d7f8
to
d17b689
Compare
a0d2de8
to
4f6978e
Compare
The function itself is kept for now because it's currently used to test the pip.metadata subpackage...
4f6978e
to
d4d2445
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #7413…