Skip to content

Vendoring updates for 22.3 (distlib, pep517, idna, tenacity) #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Oct 10, 2022

No description provided.

@pfmoore
Copy link
Member Author

pfmoore commented Oct 10, 2022

Removed rich (and pygments and typing_extensions) upgrades to see if that's what's causing the failures.

@pfmoore
Copy link
Member Author

pfmoore commented Oct 10, 2022

Yeah, the latest version of rich appears to be causing control sequences to "leak" into our test suite output. It seemed to be only happening on Ubuntu, not on Windows.

Related somehow to the rich changes around FORCE_COLOR, maybe?

@pradyunsg pradyunsg merged commit f8a2592 into pypa:main Oct 10, 2022
@pradyunsg
Copy link
Member

x-ref #11500

Related somehow to the rich changes around FORCE_COLOR, maybe?

Yup -- we set FORCE_COLOR = 1 in our CI.

@pradyunsg pradyunsg changed the title Vendoring updates for 22.3 (excludes certifi and urllib3) Vendoring updates for 22.3 (excludes certifi, urllib3, pygments, rich, typing_extensions) Oct 14, 2022
@pradyunsg pradyunsg changed the title Vendoring updates for 22.3 (excludes certifi, urllib3, pygments, rich, typing_extensions) Vendoring updates for 22.3 (distlib, pep517, idna, tenacity) Oct 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
@pfmoore pfmoore deleted the vendor branch April 26, 2023 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants