TESTING: Patch out the BASE configuration location) #11983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
added
the
skip news
1 task
pfmoore
force-pushed
the
remove_base_location
branch
from
b03dd3e to
7644854
Compare
pfmoore
force-pushed
the
remove_base_location
branch
from
7644854 to
160c9a0
Compare
|
Hmm, I'm a bit concerned that I only needed to patch out a single test to get this to work. That suggests that the original PR didn't really have enough tests. But we can worry about that when we re-introduce the functionality... |
|
OK, as this passes the tests, I consider it a sufficient "emergency fix" should no-one step up with a better resolution. |
|
No longer needed, as we reverted the original fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.