Skip to content

if installing directly from a wheel, fail if it has an invalid name or is unsupported #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

if installing directly from a wheel, fail if it has an invalid name or is unsupported #1305

wants to merge 1 commit into from

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented Nov 8, 2013

  • if installing directly from a wheel, fail if it has an invalid name or is unsupported
  • when walking links, skip invalid wheel filenames (we already skip unsupported wheels)

qwcode
qwcode reviewed Nov 8, 2013
View reviewed changes
pip/index.py
@@ -481,6 +481,9 @@ def _link_package_versions(self, link, search_name):
logger.debug('Skipping link %s; macosx10 one' % (link))
self.logged_links.add(link)
return []
if link.invalid_wheel_filename:
logger.debug('Skipping %s because the wheel filename is invalid' % link)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this change, we currently hard fail if we encounter in invalid wheel filename. the package finder crashes

@qwcode
- if installing directly from a wheel, fail if it has an invalid name…
b1fe477 
… or is unsupported

- when walking links, skip invalid wheel filenames
@qwcode
Copy link
Contributor Author

qwcode commented Nov 10, 2013

closing. will re-post another later.
I don't like the Link.invalid_wheel_filename property. too odd.
I'm thinking I will get rid of the link.wheel property, and leave Linkss ignorant of what they hold.
maybe later, when pip has a more comprehensive object model, Links might hold objects for what they link to.

@qwcode qwcode closed this Nov 10, 2013
@qwcode qwcode mentioned this pull request Nov 15, 2013
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
1 participant
@qwcode