Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2025

Incorrect indents cause some texts to be misinterpreted and render incorrectly.

Incorrect indents cause some texts to be misinterpreted and render incorrectly.
@notatallshaw
Copy link
Member

Thanks for the PR. Can you explain what's the issue with the existing indents?

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jun 23, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the ReadTheDocs preview, you'll notice that admonitions were missing or the indention was broken.

image
image

I tried to look for pre-commit linters that could catch these issues for us, neither https://github.com/rstcheck/rstcheck nor https://github.com/PyCQA/doc8 flagged these indention issues :(

@ichard26 ichard26 merged commit 98ac4a2 into pypa:main Jun 23, 2025
12 checks passed
@ichard26
Copy link
Member

Thank you for catching these! You got a keen eye :)

@ghost ghost deleted the patch-1 branch June 26, 2025 03:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants