Move unpack_url to pip.download #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts all unpack functions in the same place. Cherrypicked from a commit of qwcode
add _check_download_dir and _download_http_url to ease the understanding of unpack_http_url and unpack_file_url functions
xavfernandez
force-pushed
the
develop_moveunpack
branch
from
e889e39 to
3b3c209
Compare
dstufft
added a commit
that referenced
this pull request
Aug 28, 2014
Move unpack_url to pip.download
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts all unpack functions in the same place.
unpack_file_url and unpack_http_url are doing quite similar stuff so I factorized the common parts to ease the understanding of their similarities and differences.