linting. #2048
linting. #2048
Conversation
| @@ -827,30 +828,24 @@ def get_page(cls, link, req, skip_archives=True, session=None): | |||
| ) | |||
| except requests.Timeout: | |||
| cls._handle_fail(req, link, "timed out", url) | |||
| except SSLError as exc: | |||
There was a problem hiding this comment.
This was a weird one. pylint pointed out that SSLError is a descendant class of ConnectionError, above, so this case can never be hit.
There was a problem hiding this comment.
so the SSLError could go before ConnectionError but I'm not sure it's worth it to have a special case for SSL
There was a problem hiding this comment.
If I'm preserving status-quo behavior, this is the right refactor.
There was a problem hiding this comment.
Could file a seperate bug if this erroneous behaviour.
bukzor
force-pushed
the
buck-lint
branch
2 times, most recently
from
1b664cc to
e26337e
Compare
| req, link, reason, url, | ||
| level=2, | ||
| meth=logger.info, | ||
| ) | ||
| else: | ||
| return inst | ||
|
|
||
| @staticmethod | ||
| def _handle_fail(req, link, reason, url, level=1, meth=None): |
There was a problem hiding this comment.
looks like url and level are useless here :o
bukzor
force-pushed
the
buck-lint
branch
3 times, most recently
from
78019a8 to
14d421d
Compare
|
This is good to go imo. I realize that the consensus seems to be against pylint, but this patch does improve the quality constraints provided by CI, and provides a path to incrementally improve things. |
|
So I started to poke at pylint, and it chokes on |
|
I've updated the branch to show how i'd make pip.baseparser pylint-clean. |
|
I'm going to close this for now. If at some point the distutils import error gets fixed we can revisit using pylint. |
lock
bot
added
the
auto-locked
pip.index is now pylint clean given a couple #FIXME:pylint:disable comments.
If i'm successful in my plans, my next few refactors should fix those.