Skip to content

Make --no-clean work in tox #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Make --no-clean work in tox #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef522ac
Make a cleanup test fail to demonstrate bugginess.
habnabit Apr 15, 2015
ce3ce94
Remove an unconditional .remove_temporary_source()
habnabit Apr 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pip/req/req_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,5 @@ def install(self, install_options, global_options=(), *args, **kwargs):
if (requirement.conflicts_with and
requirement.install_succeeded):
requirement.commit_uninstall()
requirement.remove_temporary_source()

self.successfully_installed = to_install
2 changes: 1 addition & 1 deletion tests/functional/test_install_cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_no_clean_option_blocks_cleaning_after_install(script, data):
'install', '--no-clean', '--no-index', '--build', build,
'--find-links=%s' % data.find_links, 'simple',
)
assert exists(build)
assert exists(build / 'simple' / 'setup.py')


@pytest.mark.network
Expand Down