Skip to content

[WIP] Added --save option to install command #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

blarghmatey
Copy link

@blarghmatey blarghmatey commented Jul 25, 2015

I added a pair of new command options to the install command. --save
will append the specified packages to the end of the 'requirements.txt'
file. --save-dest will take a filename or path argument and the
specified packages will be appended to the given file.

I am opening this pull request to see if there is any interest in adding this to pip and if so to gather any feedback about things that I may be doing wrong.

Review on Reviewable

@piotr-dobrogost
Copy link

For information, this feature was requested in issue #1479

@blarghmatey
Copy link
Author

Is this a desired PR? If so, are there any glaring issues with it? I'm happy to address any shortcomings. Also, advice on the best file/location to add appropriate tests would be appreciated. Trying to navigate the test structure left me rather disoriented.

Fixed broken link to article comparing setup.py to requirements.txt
@noelvo
Copy link

noelvo commented Dec 3, 2015

This PR is great. I hope it will get merged soon. I have tested out and it works just fine. --save option will save developers a lot of time.

@yassineAlouini
Copy link

Great one. Hopefully, this will get merged soon 👍

@fitoria
Copy link

fitoria commented Jan 13, 2016

+1

I added a pair of new command options to the install command. --save
will append the specified packages to the end of the 'requirements.txt'
file. --save-dest will take a filename or path argument and the
specified packages will be appended to the given file.
@bitzip
Copy link

bitzip commented Jan 18, 2016

+1

@dstufft dstufft closed this May 18, 2016
@dstufft
Copy link
Member

dstufft commented May 18, 2016

Accidentally closed this, reopening. Sorry!

@dstufft dstufft reopened this May 18, 2016
@BrownTruck
Copy link
Contributor

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

I added a pair of new command options to the install command. --save
will append the specified packages to the end of the 'requirements.txt'
file. --save-dest will take a filename or path argument and the
specified packages will be appended to the given file.

I am opening this pull request to see if there is any interest in adding this to pip and if so to gather any feedback about things that I may be doing wrong.

---

*This was migrated from pypa/pip#2988 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@BrownTruck BrownTruck added asked to reparent auto-bitrotten PRs that died because they weren't updated and removed asked to reparent labels May 19, 2016
@BrownTruck
Copy link
Contributor

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

@BrownTruck BrownTruck closed this May 26, 2016
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-bitrotten PRs that died because they weren't updated auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants