Fix user directory expansion when HOME=/ #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouge8
force-pushed
the
fix-py26-home-slash
branch
from
904daae to
c3fdbae
Compare
|
I rebased off the latest develop and it looks like the tests are passing now. |
|
I think it would make more sense to provide a fixed version of |
|
@xavfernandez done and updated the rest of the codebase to use it. |
|
Great ! Could you also add a changelog to CHANGES.txt ? |
rouge8
force-pushed
the
fix-py26-home-slash
branch
from
7b17622 to
2adf569
Compare
|
Done! |
added 3 commits
September 29, 2015 16:01
On versions of CPython affected by <http://bugs.python.org/issue14768> (Python 2.6, some versions of Python 2.7 and 3.3), `os.path.expanduser('~/path')` returns `//path` rather than `/path` when `HOME=/`. This affects pip when `os.path.expanduser('~/.cache/pip')` is expanded to `/\\\\.cache/pip`. Although `HOME=/` is probably uncommon on most Linux systems, it is extremely common in Docker images. Fixes pypa#2996.
rouge8
force-pushed
the
fix-py26-home-slash
branch
from
2adf569 to
73a439e
Compare
xavfernandez
added a commit
that referenced
this pull request
Sep 29, 2015
Fix user directory expansion when HOME=/
|
Thanks ! 👍 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On versions of CPython affected by http://bugs.python.org/issue14768 (Python 2.6, some versions of Python 2.7 and 3.3),
os.path.expanduser('~/path')returns//pathrather than/pathwhenHOME=/. This affects pip whenos.path.expanduser('~/.cache/pip')is expanded to/\\\\.cache/pip. AlthoughHOME=/is probably uncommon on most Linux systems, it is extremely common in Docker images.Fixes #2996.