Skip to content

Change message to explain better what pip is doing #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change message to explain better what pip is doing #377

wants to merge 1 commit into from

Conversation

flavioribeiro
Copy link

Fix issue #376

@hltbra
Copy link
Contributor

hltbra commented Nov 25, 2011

Talking to people in #pip @ freenode, carljm, jezdez and I found that "Retrieving" is a little better message than "Searching for" and "Downloading/Unpacking". So, I would change your request to use this message and add it to CHANGES.

@hltbra
Copy link
Contributor

hltbra commented Nov 25, 2011

Hey, sorry. I did more confusion than helping here. The "Retrieving" message is not a good option, since we have a "Downloading .." message while in that step.

Well, have no other idea right now. But "Looking for" seems to be a better message at the moment, since it is analyzing lots of links looking for download links.

Maybe @jezdez or @carljm have a better idea sooner than me.

@bernardobarreto
Copy link
Contributor

+1 for "Looking for".

would be nice to merge this as quickly as possible, this confuse people:
you're reading "Downloading/unpacking", and after you see a download in proccess... doesn't make sense..

@carljm
Copy link
Contributor

carljm commented Apr 16, 2012

I'm afraid I don't understand what is confusing or misleading about the current message. It seems perfectly intuitive to me that pip would tell you "I'm downloading/unpacking X" and then after that (indented) give you more details about the process of doing so. I don't see any implication that the line "Downloading/unpacking X" means it has already finished doing so. I don't see any significant advantage to "Looking for X" - in fact, that seems misleading to me as pip is doing a lot more than just looking for something.

Closing this pull request in any case, as the original author doesn't seem to have interest in updating it, and I don't think "Searching for" is a good message.

@carljm carljm closed this Apr 16, 2012
@bernardobarreto
Copy link
Contributor

@carljm sorry, I misunderstood. I didn't see the indentation, yes makes sense as you said "Downloading/unpacking" and then it shows more detail (indented), the indentation is the key point.

nevertheless, I still think "Downloading/unpacking" isn't good enough, pip is doing more then just looking for some package and it is also doing more than just downloading and unpacking.

I think the message should be Installing, because it makes the download, the unpack and it also installs the package.

@TC01
Copy link
Contributor

TC01 commented May 31, 2012

This is a bit old.. but for what it's worth- I think Downloading\Unpacking is fine if the package exists. I agree that it doesn't imply it's finished doing this, just that it's in the process of doing so.

The problem is when the package does not exist. Currently, the output tells you that pip is downloading and unpacking a package- then tells you that it has failed to find anything to download. This is confusing, because I will often type "pip install somepkg", see the "Downloading/unpacking somepkg" message and think that pip has found something.. only to see later that it hasn't.

I'd suggest first a no-indentation message "Searching for somepkg"; then another no-indentation message saying "Installing somepkg" (or Downloading/Unpacking if this is preferred) that pops up only if pip actually found a package. And then that second message can be followed by all the existing indented output for downloading, unpacking, and installing.

@hltbra hltbra mentioned this pull request Mar 24, 2013
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants