Skip to content

travis: use container builds except for pypy #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

travis: use container builds except for pypy #4587

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2017

No description provided.

pradyunsg
pradyunsg previously approved these changes Jul 1, 2017
@@ -20,6 +22,7 @@ matrix:
python: nightly
- env: TOXENV=pypy
python: pypy
sudo: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you could do that!

@pradyunsg pradyunsg mentioned this pull request Jul 1, 2017
@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes C: automation Automated checks, CI etc labels Jul 1, 2017
@pradyunsg
Copy link
Member

The build runs for the same amount of time, since the longest job is pypy and no changes made there. The total times (∑time for all jobs) has reduced drastically.

This PR: 2 hrs 40 min 50 sec
master: 4 hrs 40 min 19 sec

Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this doesn't affect total time, it will improve capacity.

@pradyunsg pradyunsg dismissed their stale review July 1, 2017 19:39

There seems to be a better way to do this...

@ghost ghost closed this Jul 1, 2017
@ghost
Copy link
Author

ghost commented Jul 1, 2017

closed per @pradyunsg's comments.

@ghost ghost deleted the patch-1 branch July 1, 2017 20:17
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants