Skip to content

PR ci testing - add assertion messages #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PR ci testing - add assertion messages #538

wants to merge 1 commit into from

Conversation

pnasrat
Copy link
Contributor

@pnasrat pnasrat commented May 19, 2012

No description provided.

@pnasrat pnasrat mentioned this pull request May 19, 2012
@travisbot
Copy link

This pull request fails (merged 75af797 into e0db44e).

@pnasrat
Copy link
Contributor Author

pnasrat commented May 19, 2012

Testing CI on Pull Requests successful - known flaky test as per Issue #530

@pnasrat pnasrat closed this May 19, 2012
@hltbra
Copy link
Contributor

hltbra commented May 20, 2012

Hi @pnasrat,

I remember I always had trouble using nose and native python assertions because the lack of message help, and IIRC @RonnyPfannschmidt was trying to change nose by pytest in pip, and assertions were one of the reasons.

I think it would be nice to define a standard for assertions, like using nose's assert functions or change test runner for pytest.

Have you ever thought about it?

@pnasrat
Copy link
Contributor Author

pnasrat commented May 20, 2012

@hltbra There is a seperate issue already for looking at pip testing in general, which I hope to get to once I get back from travelling (ie in a few weeks).

This was really a simple pull request to trigger, but I did a meaningful but disposable changes to test the CI integration.

Thanks for the pointers, we definitely could do better here.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants