--user fixes part 1 #548
Merged
--user fixes part 1 #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passes all but known flaky #530 in travis. |
|
This has gone through extensive review already - did a quick once over and still lgtm. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per exchange with Paul/Carl, this is part 1 of a breakup of pull request #511
full plan is here: https://gist.github.com/2822510
part 1:
A new system_site_packages option for reset_env, that creates a --system-site-packages virtualenv.
This is needed to test --user install scenarios (coming in subsequest pull requests).
Without this option, the virtualenv created by reset_env doesn't have the user site on the sys.path.
pypi_server.PyPIProxy.setup() now occurs in a sitecustomize.py file (not a pth file).
This was necessary to prevent pkg_resources.working_set corruption (see comment in the code).
An accurate pkg_resources.working_set is required so that pkg_resources.get_distribution (used in pip.req)
can find --user installed distributions