Skip to content

--user fixes part 1 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2012
Merged

--user fixes part 1 #548

merged 1 commit into from
May 31, 2012

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented May 31, 2012

per exchange with Paul/Carl, this is part 1 of a breakup of pull request #511
full plan is here: https://gist.github.com/2822510

part 1:

A new system_site_packages option for reset_env, that creates a --system-site-packages virtualenv.
This is needed to test --user install scenarios (coming in subsequest pull requests).
Without this option, the virtualenv created by reset_env doesn't have the user site on the sys.path.

pypi_server.PyPIProxy.setup() now occurs in a sitecustomize.py file (not a pth file).
This was necessary to prevent pkg_resources.working_set corruption (see comment in the code).
An accurate pkg_resources.working_set is required so that pkg_resources.get_distribution (used in pip.req)
can find --user installed distributions

@travisbot
Copy link

This pull request fails (merged db2628d into 2f84e14).

@pnasrat
Copy link
Contributor

pnasrat commented May 31, 2012

Passes all but known flaky #530 in travis.

@pnasrat
Copy link
Contributor

pnasrat commented May 31, 2012

This has gone through extensive review already - did a quick once over and still lgtm.

pnasrat added a commit that referenced this pull request May 31, 2012
@pnasrat pnasrat merged commit 6c68db6 into pypa:develop May 31, 2012
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants