Followup build and src dir fixes #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved src_dir back to cwd for now. build_dir is still created in the system's temporary dir (tempfile.gettempdir()), but always as "pip-build".
This reverts commit 20f8ce2.
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this pull request is a followup to #516. To recap: there were two issues with the solution I provided in that request:
--no-installfollowed by--no-download, because the temporary directory pip created was different each time.srcdir was bad- it could not be a temporary directory, it needed to be somewhere permanent.So what I've done is changed the temporary
builddirectory to always be called pip-build (ex: /tmp/pip-build) , fixing issue 1, and movingsrcback into cwd to fix issue 2. I have the latter still flagged as a FIXME because I do think that things shouldn't arbitrarily be created in cwd- but it currently seems to be the best possible option.