Skip to content

Address #5031: freeze non-vcs editable installs as editable #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2018
Merged

Address #5031: freeze non-vcs editable installs as editable #5905

merged 3 commits into from
Nov 5, 2018

Conversation

cjerdonek
Copy link
Member

This addresses #5031.

Note that if this PR is okay, I'd prefer to land PR #5881 first, which would require rebasing this one.

@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: vcs pip's interaction with version control systems like git, svn and bzr labels Oct 21, 2018
@cjerdonek cjerdonek mentioned this pull request Oct 21, 2018
Closed
@cjerdonek cjerdonek force-pushed the issue-5031-freeze-non-vcs-editable branch from 73eb26f to 237be13 Compare October 21, 2018 04:50
@cjerdonek cjerdonek added C: freeze 'pip freeze' related C: editable Editable installations labels Oct 21, 2018
@cjerdonek cjerdonek force-pushed the issue-5031-freeze-non-vcs-editable branch 2 times, most recently from ddc421b to 6f63091 Compare October 21, 2018 07:04
@cjerdonek cjerdonek force-pushed the issue-5031-freeze-non-vcs-editable branch from 6f63091 to 20ab0b8 Compare October 22, 2018 09:20
@cjerdonek
Copy link
Member Author

Rebased.

xavfernandez
xavfernandez reviewed Oct 22, 2018
View reviewed changes
@cjerdonek
Copy link
Member Author

@xavfernandez Would you mind taking another look at this patch?

@cjerdonek
Copy link
Member Author

Thanks a lot for the review, @xavfernandez. I appreciate it.

@cjerdonek cjerdonek merged commit 3803ce3 into pypa:master Nov 5, 2018
@cjerdonek cjerdonek deleted the issue-5031-freeze-non-vcs-editable branch November 5, 2018 22:21
@cjerdonek cjerdonek mentioned this pull request Dec 13, 2018
Closed
@pradyunsg pradyunsg added this to the 19.0 milestone Jan 3, 2019
@cjerdonek cjerdonek mentioned this pull request Jan 11, 2019
Merged
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: editable Editable installations C: freeze 'pip freeze' related C: vcs pip's interaction with version control systems like git, svn and bzr type: enhancement Improvements to functionality
Projects
None yet
Milestone
19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cjerdonek @xavfernandez @pradyunsg