Skip to content

pypy test fixes for issue #616 and #617 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2012
Merged

pypy test fixes for issue #616 and #617 #619

merged 2 commits into from
Jul 30, 2012

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented Jul 30, 2012

this handles pypy test failures for #616 and #617
#616:

the fix is to skip testing the user scheme in pypy. --user installs are broke in pypy.
previous to skipping the tests most of the errors were related to improperly locating 'no-global-site-packages.txt', which is related to the fix for #617. see below.
#617

the fix I made is to add a workaround to compensate for this bug: pypa/virtualenv#306
I think virtualenv misreports the lib_path for pypy

@travisbot
Copy link

This pull request passes (merged 483adaa into 0fcfe0f).

@qwcode
Copy link
Contributor Author

qwcode commented Jul 30, 2012

this busted other pypy tests.
so, I fixed env.lib/env.lib_path for pypy, but that now throws off the site-packages definition which doesn't apply for pypy
`self.site_packages = self.lib/'site-packages'

pnasrat added a commit that referenced this pull request Jul 30, 2012
pypy test fixes for issue #616 and #617
@pnasrat pnasrat merged commit 57dcec0 into pypa:develop Jul 30, 2012
@qwcode
Copy link
Contributor Author

qwcode commented Jul 30, 2012

don't think you noticed my comment about how this busted other tests.
I pushed up a fix right after you merged.

@qwcode
Copy link
Contributor Author

qwcode commented Jul 30, 2012

let me do a another pull to get that commit in

@pnasrat
Copy link
Contributor

pnasrat commented Jul 30, 2012

Yeah sorry - merging before coffee.

@qwcode
Copy link
Contributor Author

qwcode commented Jul 30, 2012

just posted another pull, and will wait to confirm failures are down to the 2 remaining ones that I expect before merging.
(the 2 I haven't looked at)

pnasrat added a commit that referenced this pull request Jul 30, 2012
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants