upper case url reqs not aliased with name.lower() like other forms #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consider this requirements file
and know that:
what you end up with in site-packages is metadata for both being installed:
Pygments is not considered the same as "pygments".
this does not happen, when the requirements file is this:
I've also seen cases like this with "Django", where Django is installed with a url link, and some other requirement depends on "django"
the diff here is very small, and I added a test, which required some new packages. the fix amounts to closing a loophole in the way 'unnamed' requirements were being added to the requirement set. they were bypassing the method that adds the lower case alias.