Add Scheme model and use for wheel installation #7310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
pradyunsg
reviewed
Nov 7, 2019
Now we have a nicely-typed interface to the calculated scheme, and some more documentation for the same.
This was already happening in locations.distutils_scheme, we're just reusing the existing work instead of doing it again.
chrahunt
force-pushed
the
refactor/scheme
branch
from
e320986 to
6fa64a6
Compare
xavfernandez
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
👍 and btw it reminds me that we should really extract the wheel installation code into a PyPA library that could be used by the different installer.
I even started copying (now obsolete) code over to https://github.com/xavfernandez/cric almost 3 years ago 👴
|
Thanks both of you for reviewing! I'll merge this now, if anyone sees further issues you know where to find me. :) |
|
Yea -- the point here is re-usability of all the build logic code once we're at a point where the "core" components of that are no longer tied to pip's internals. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a Scheme model that represents our installation directories, and we use it to handle our wheel installs and de-duplicate the header install directory calculation logic.
Progresses #6052.