Remove unnecessary InstallRequirement cleanup in install_given_reqs #7516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_given_reqs is only called from InstallCommand.run, which calls RequirementSet.cleanup_files, which calls InstallRequirement.remove_temporary_source for each InstallRequirement, so the call here was not necessary. We have test coverage affirming this still works as expected in tests/functional/test_install_cleanup.py.
chrahunt
added
skip news
sbidoul
approved these changes
Dec 26, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallCommand.run:install_given_reqs(sole caller)RequirementSet.cleanup_filesInstallRequirement.remove_temporary_sourcefor eachInstallRequirementso a call to
InstallRequirement.remove_temporary_sourceininstall_given_reqsis not necessary and has been removed.We have test coverage affirming this still works as expected in
tests/functional/test_install_cleanup.py.Progresses #2779.